water-fountains / proximap

a responsive Angular 6 web app for finding nearby fountains
https://beta.water-fountains.org
Other
16 stars 9 forks source link

reprocessing single fountain leads to duplicate on map #299

Open mmmatthew opened 5 years ago

mmmatthew commented 5 years ago

Describe the bug Fountains in Bergama, when refreshed, appear twice in the list

To Reproduce Steps to reproduce the behavior:

  1. Go to https://water-fountains.org/tr-be?l=de&i=Q67141827
  2. Click on 'refresh'

Expected behavior The reprocessed fountain should replace the already existing fountain in the list. For some reason the pre-existing fountain is not found, so the reprocessed fountain is added as if it were new. The updating behavior seems to work in Zurich.

ralfhauser commented 5 years ago

Cannot entirely reproduce - when I refresh it e.g. in Chrome, the number of fountains remains the same, but after refreshing, it no longer uses the Q-# but re-pops-up with https://water-fountains.org/tr-be?l=de&lat=39.12419167&lng=27.18775278

mmmatthew commented 5 years ago

Even though the number of fountains stays the same, the fountain appears twice in the list. The change in URL is by design, because the refresh cannot assume that any of the fountain properties (e.g. QID) remain unchanged.