waterloo-rocketry / minerva-rewrite

The rewrite of Waterloo Rocketry's custom slackbot
MIT License
1 stars 2 forks source link

Implement rollback mechanism and workflow exit during application failure #51

Closed shirleyfyx closed 12 months ago

shirleyfyx commented 1 year ago

This change is Reviewable

shirleyfyx commented 1 year ago

The deployment script fails when triggered by an intentional error introduced in the index.ts file. image

shirleyfyx commented 1 year ago

After communicating with @QuantumManiac, we have decided not to implement the rollback system.

shirleyfyx commented 1 year ago

The script passes with successful deployment and this deployment script checks if PM2 successfully starts the process.

Considering the current stage of development where index.ts does not yet contain functional code, temporary adjustments were made to the deployment script. This change ensures that our CI/CD pipeline passes without errors, despite the absence of operational code in index.ts.

The original script was failing because it expected functional application logic, which isn’t present at this stage.

image