search

waydabber / BetterDisplay-localization

BetterDisplay-localization
6 stars 20 forks source link

Added Spanish Translation #14

Closed stonkol closed 8 months ago

waydabber commented 8 months ago

Hi @stonkol, I don't see any new Spanish text in the request, only changes that reflect the earlier baseline you were working on (which is fine, this does not cause any issues during import). Is this just a test PR? :)

stonkol commented 8 months ago

Is in "Localized Contents > es.xliff" The one that have added 892 lines.

waydabber commented 8 months ago

Yes, I see the difference, it's just that if I look at the diff, I don't see any new Spanish text in it, only differences that are caused by the translation source version difference. I recommend making a PR when there is actually new translation invovled. I'll approve it then, import it into the app and update the repo myself with the resulting updated localization files.

stonkol commented 8 months ago

At least from my side, I can see the part I have translated.

You need to click "Load Diff", which by default is not previewing.

389gn80

waydabber commented 8 months ago

Lol, sorry, you are right. I missed the part that large diffs are not rendered by default. :) Sorry about that.

waydabber commented 8 months ago

I will merge it soon when I can import it into the app and export and update the entire localization file as this PR changes the Source Contents as well back to an outdated version due to the transition to versioning. I will need to quickly fix that.

stonkol commented 8 months ago

Lol, sorry, you are right. I missed the part that large diffs are not rendered by default. :) Sorry about that.

No worries also was a little bit confusing for me lolol.

Cool, I will add more translations when I have time.