search

waydabber / BetterDisplay-localization

BetterDisplay-localization
5 stars 17 forks source link

[`pt-PT`] Corrections and completion of the translation. #38

Closed 0rangeFox closed 2 months ago

0rangeFox commented 2 months ago

Hey 👋, here's the first PR for the pt-PT language with the aim of correcting and adding the missing translations from the last file.

0rangeFox commented 2 months ago

Hey @waydabber, is it possible to add @nunoebarros as a reviewer to keep track of the progress and get his approval for the new changes as well? Can you also link to this PR for issue #32?

waydabber commented 2 months ago

Hi @0rangeFox - when you mentioned #32 GitHub auto linked this PR to that. :) But the PR is still marked as draft and work in progress. Is that intentional?

0rangeFox commented 2 months ago

Hi @0rangeFox - when you mentioned #32 GitHub auto linked this PR to that. :) But the PR is still marked as draft and work in progress. Is that intentional?

Well, I don't think it's going to the Development section here in PR, but I've marked it as Draft and it's not complete yet, it still needs to be worked on and the missing translations to be filled in.

Another question, could you explain how I can merge the new translation file with the current one? I think it's a bit outdated compared to the last translation.

waydabber commented 2 months ago

Ok. I set it to "Ready to review", however I can't add any other reviewer. Should I just merge it? @nunoebarros can take a look at it and suggest corrections anytime I think.

0rangeFox commented 2 months ago

It's not available yet, I've only made the corrections and the rest of the translations have yet to be translated.

Another question, could you explain how I can merge the new translation file with the current one? I think it's a bit outdated compared to the last translation.

And how can I do this?

waydabber commented 2 months ago

Hi, the best course of action is that I merge the changes, import the file into the app and export an updated file you can continue working on. Otherwise the changes need to be merged if there are conflicts.

waydabber commented 2 months ago

(ok, there were no conflicts... :)).

0rangeFox commented 1 month ago

Ohhh, I didn't want you to merge, but you could have taken control of this PR and updated things yourself without having to merge. As I said things were still being corrected and translated. But I'd rather do it all at once in this PR than creating several for each correction/translation. Now it's gone and that's that.

waydabber commented 1 month ago

Oh, ok, sorry. You can create an other one and I'll keep it open, or you can just work in a fork you created and update strings whenever there is a change in this repo as you work. You can also work incrementally and create PRs periodically there are some changes that improve the situation instead of waiting for a PR until everything is perfect - this way whenever I create a version, the best currently available translation will be included in it.