search

wayfair-contribs / plentymarkets-plugin

Wayfair plugin for use in the Plentymarkets eCommerce ERP system
https://marketplace.plentymarkets.com/en/plugins/integration/wayfair_6273
Other
4 stars 3 forks source link

OLD: Avoid using IDs of Warehouses that do not exist #192

Closed jhoule86 closed 3 years ago

jhoule86 commented 3 years ago

Filters out invalid Warehouse IDs (ex: Warehouse is deleted but mapping in Wayfair plugin UI was not manually removed by user) at lookup time in the WarehouseSupplierRepository module.

Note: a large amount of the changes is actually just me renaming local variables from mappingData to results to make the code more readable.

Also, adds some comments about the fact that we need to do more detailed filtering on the Warehouse for an order, as mentioned in https://github.com/wayfair-contribs/plentymarkets-plugin/issues/92.

jhoule86 commented 3 years ago

PR was created before plugin version change, making this branch muddy. Replacing this with a new PR.