new DryRunNotSupportedException to throw when a Wayfair API does not support dryRun and the supplier is testing
new Wayfair\Core\Dto\General\DocumentDTO replaces Wayfair\Core\Dto\ShippingLabel\ResponseDTO as it is used for more Document types than just Shipping Labels
Better log messages for Document Fetching
More logging (positive and negative) around Shipping Labels and Tracking Numbers in ShipmentRegisterService
Removals
Wayfair\Core\Dto\ShippingLabel\ResponseDTO replaced by Wayfair\Core\Dto\General\DocumentDTO
Cryptic / erroneous log messages
Modifications
Fixes https://github.com/wayfair-contribs/plentymarkets-plugin/issues/201: Attempting to register a PO with RegisterPurchaseOrderService when the plugin is in test / dryRun mode will result in a DryRunNotSupportedException, before the call is made to the Wayfair API, resulting in Plenty to report an "Internal error" as we log the Exception:
Fix an Exception logging statement in RegisterPurchaseOrderService that was missing the required method element, which lead to Plentymarkets catching and logging a fatal Exception about the bad logging code, instead of the plugin reporting registration failures to the Plentymarkets log.
only do "using tracking number X" logs in ShipmentRegisterService if tracking number exists and is not empty
Document Fetching mechanism throws Exception when HTTP response code from Wayfair is not in the 200 range, as the data returned is undetermined.
Document Fetching mechanism no longer refers to Documents as "labels" or "shipping labels"
FetchDocumentContract uses `DocumentDTO instead of Shipping Label DTO type
FetchDocumentService uses DocumentDTO instead of ShippingLabel DTO type
Additions
DryRunNotSupportedException
to throw when a Wayfair API does not support dryRun and the supplier is testingWayfair\Core\Dto\General\DocumentDTO
replacesWayfair\Core\Dto\ShippingLabel\ResponseDTO
as it is used for more Document types than just Shipping LabelsShipmentRegisterService
Removals
Wayfair\Core\Dto\ShippingLabel\ResponseDTO
replaced byWayfair\Core\Dto\General\DocumentDTO
Modifications
Fixes https://github.com/wayfair-contribs/plentymarkets-plugin/issues/201: Attempting to register a PO with
RegisterPurchaseOrderService
when the plugin is intest
/dryRun
mode will result in aDryRunNotSupportedException
, before the call is made to the Wayfair API, resulting in Plenty to report an "Internal error" as we log the Exception:Fix an Exception logging statement in
RegisterPurchaseOrderService
that was missing the requiredmethod
element, which lead to Plentymarkets catching and logging a fatal Exception about the bad logging code, instead of the plugin reporting registration failures to the Plentymarkets log.only do "using tracking number X" logs in
ShipmentRegisterService
if tracking number exists and is not emptyDocument Fetching mechanism throws Exception when HTTP response code from Wayfair is not in the
200
range, as the data returned is undetermined.Document Fetching mechanism no longer refers to Documents as "labels" or "shipping labels"
FetchDocumentContract
uses `DocumentDTO instead of Shipping Label DTO typeFetchDocumentService
usesDocumentDTO
instead of ShippingLabel DTO type