wazho / DungeonGenerator

Dungeon Generator for XAOCX project, it publishes on Unity extension.
5 stars 0 forks source link

Issue #1 #22

Closed kertaskids closed 7 years ago

kertaskids commented 7 years ago

Hello, I have some pieces of advice for little issues. These issues supposed to be opened in various issue categories. But now, I just sum it up because it needs further discussion.

  1. Change the variable name of private ConnectionArrowType _arrow; to _arrowType;. And also public ConnectionArrowType Arrow { ... } to ArrowType { ... } in Alphabet.cs. These are to prevent the confusion.

  2. Change the declaration of this method: public static void DrawDics() to be: ... DrawDiscs or ... DrawDisc.

  3. It is better to loads the textures in a single class, like Style.cs. For example we have "delete.png, edit.png, etc". Another benefit, we can implement tab-button states like this. But problems may occur. For example,

    private static Texture2D _miniButtonLeftNormalTexture; 
    _pointsInterfaceStyle = new GUIStyle(EditorStyles.miniButtonLeft);

    The GUIStyle() can only be called inside OnGUI(). Image below is an example. capture

*Many more issues coming ;-)

wazho commented 7 years ago

Has finished.

Toggle.