Closed sovanyio closed 5 years ago
@ifahrentholz not sure how to test it locally on my machine.
i executed npm install
and npm run test
on this branch, and the test fails:
$ npm run test
> aem-clientlib-generator@1.4.1 test D:\Develop\github\wcm-io-frontend\aem-clientlib-generator
> mocha
Test output
1) should create files correctly
0 passing (127ms)
1 failing
1) Test output should create files correctly:
Uncaught AssertionError [ERR_ASSERTION]: content of clientlibs-root\myPrestructuredLibrary\css.txt is not expected
+ expected - actual
#base=css
-style\lib.css
-style\styling.css
-vendor\main.css
+style/lib.css
+style/styling.css
+vendor/main.css
at test\TestCase.test.js:70:22
at Array.forEach (<anonymous>)
at Walker.<anonymous> (test\TestCase.test.js:56:17)
at endReadableNT (_stream_readable.js:1094:12)
at process._tickCallback (internal/process/next_tick.js:63:19)
the same test run supports success if executed on the master branch. so i'm not sure if this PR really improves something (or what was the problem it should fix - we are using the aem-clientlib-generator on windows systems as well - without problems).
Hi @sovanyio, since our tests are breaking with your contribution we will not merge your PR. If you still have issues we're fine to reopen the issue.
@stefanseifert Can you please test with your windows-machine if the pull request will not break builds ? Since @bubaumann used the path.posix explicit to fix windows builds I'm not entirely sure if we can remove "posix" here..