search

wcm-io-frontend / aem-clientlib-generator

Creates configuration files for AEM ClientLibs and synchronizes assets.
Apache License 2.0
62 stars 32 forks source link

Breaking change after bumping yargs #40

Closed CezCz closed 3 years ago

CezCz commented 3 years ago

Yargs 17.0.1 requires Node 12 as per: https://github.com/yargs/yargs/blob/master/package.json#L114

When bumping the lib here, we should also bump required node version here: https://github.com/wcm-io-frontend/aem-clientlib-generator/blob/master/package.json#L36 And if we follow semantic release, that should be a major release as it is a breaking change.

vladbailescu commented 3 years ago

@ifahrentholz , this seems to have been caused by https://github.com/wcm-io-frontend/aem-clientlib-generator/commit/7247c0163f42dd6c9cd702d368cfa92175afc295, could that be reverted and a new release pushed?

ifahrentholz commented 3 years ago

Hi @CezCz, Hi @vladbailescu, I've released the new Version 1.7.7 and used yargs v16.2.0. This should fix the problem.