Closed robin-wang closed 3 years ago
Hi @robin-wang , I have pulled the request, documented the comments and uploaded the micro data to the link you shared with me (i.e., https://1drv.ms/u/s!Asjjf4e9y-vXtB0oC9mFFdAetCwO?e=yUYvla). Please correct me if I misundertand anything. Also, I am a little doubtful about the reference step in the issue. How do I "refer to the github working branch created for [Name-SurveyName]"? Thank you in advance!
You might see I updated the name of your pull request for easier reference. Re your question, you can see that there are several branches in addition to the MAIN branch. The other two are created specifically for the surveys to be edited.
In order to commit to the desginated branch, you have the option of choosing which branch you would be working on in the Github Desktop interface.
@imarabbit
You might see I updated the name of your pull request for easier reference. Re your question, you can see that there are several branches in addition to the MAIN branch. The other two are created specifically for the surveys to be edited.
In order to commit to the desginated branch, you have the option of choosing which branch you would be working on in the Github Desktop interface.
@imarabbit
Thank you Robin!
@imarabbit Please let me know if you have any questions concerning switching branches to make this work. I also confirm that Angola2006-07 data should be ready for you as we speak.
Cheers!
@imarabbit Please let me know if you have any questions concerning switching branches to make this work. I also confirm that Angola2006-07 data should be ready for you as we speak.
Cheers!
I have no doubts about switching branches but I'm not sure from which branch to which branch I should go when I pull requests. So I should create a new branch JIANING, and then pull requests from JIANING branch to the [SURVEY-NAME] branch, not from [SURVEY-NAME] branch to the MAIN branch (as I have done before), is that correct? Also, I have access to the data. Very thoughtful of you!
WORKFLOW DOC
{FOR REVIEWERS}
{FOR CODERS} A. General Procedural Steps
[x] Rebase current branch based on Master, ensure your branch is the latest. Tutorial: Rebasing your project branch onto another branch https://docs.github.com/en/desktop/contributing-and-collaborating-using-github-desktop/syncing-your-branch#rebasing-your-project-branch-onto-another-branch
[x] Run script without error
[x] Pass internal quality checking (the embedded quality check result: successfully produced value for the indicators and check if there're flags that the indicator value produced is too off from the published data)
[x] Document as comments any notable changes/caveats (if any)
[x] When Fully Completed Survey Edits, proceed to record hours worked: https://forms.gle/tLh7fxCMMsLobGHA6
B. Checklist and Guidance
[x] ANC 【c_anc_ski available, others not available】
[x] Delivery Care 【not available】
[x] PNC 【not available】
[x] Child Vaccination (search receive/month in birth.dta. if unknown vaccine pops up, search definition in DHS report) 【not available】
[x] Child Illness 【only c_fever and c_fevertreat can be generated】
[x] Child Mortality
[x] Sleeping Under Bednet 【no specific case】
[x] Child Anthropometrics 【hc70 and hc71 not available, specific weight extracted】
[x] Reproductive Health【not available】
[x] Female Anthropometrics and Cancer Screening【not available】
[x] Hospitalisation, NCD & HIV 【not available】
Hospitalisation, general observations
Hypertension treatment , blood pressure measure in the past or during the survey, for example check hm.dta/ind.dta/men.dta (generate a_bp_treat a_bp_sys a_bp_dial a_bp_meas a_hi_bp140 a_hi_bp140_or_on_med from ind.dta & men.dta by combining them)
Note from WB team for reference: "don't worry if you cannot find men.dta, not all surveys have it. if it is collected from ind.dta and men.dta seperately (some survey have female & male questionnarie, collecting these data seperately), you will need to combine these 2 dataset, generating these indicators and merge them back to hm.dta. If only from ind.dta or men.dta, i.e. only for female or male, don't generate these variables. If a new/survey-specific datafile occurs, it is highly likely that it contains info. for 13.do. "
Diabetes treatment/measure in the past (for example, a_diab_treat)
HIV, general observations
HIV questionnaire might exsit in Section 4 of "HEALTH ISSUES QUESTIONNAIRE". If they don't ask hiv test results, they are not helpful. but please document these observations.
[x] Cross-validate statistics in survey report, if applicable.
[x] Reference the NAME-SURVEY branch when your edits are finalised.
[x] Update micro data in Onedrive
[x] Examine Quality Checking Output Files