wengxyu1030 / MIS

This is the repository for MIS, which is consistent with DHS in structure, covered a limited set of indicators that HEFPI is looking for.
1 stars 0 forks source link

Angola2011-JW #2

Closed robin-wang closed 3 years ago

robin-wang commented 3 years ago

WORKFLOW DOC

{FOR REVIEWERS}

{FOR CODERS} A. General Procedural Steps

B. Checklist and Guidance

jianingwwww commented 3 years ago

Hi @robin-wang , I have pulled the request, documented the comments and uploaded the micro data to the link you shared with me (i.e., https://1drv.ms/u/s!Asjjf4e9y-vXtB0oC9mFFdAetCwO?e=yUYvla). Please correct me if I misundertand anything. Also, I am a little doubtful about the reference step in the issue. How do I "refer to the github working branch created for [Name-SurveyName]"? Thank you in advance!

robin-wang commented 3 years ago
Screenshot 2021-06-01 at 12 37 30 AM Screenshot 2021-06-01 at 12 38 47 AM

You might see I updated the name of your pull request for easier reference. Re your question, you can see that there are several branches in addition to the MAIN branch. The other two are created specifically for the surveys to be edited.

In order to commit to the desginated branch, you have the option of choosing which branch you would be working on in the Github Desktop interface.

@imarabbit

jianingwwww commented 3 years ago
Screenshot 2021-06-01 at 12 37 30 AM Screenshot 2021-06-01 at 12 38 47 AM

You might see I updated the name of your pull request for easier reference. Re your question, you can see that there are several branches in addition to the MAIN branch. The other two are created specifically for the surveys to be edited.

In order to commit to the desginated branch, you have the option of choosing which branch you would be working on in the Github Desktop interface.

@imarabbit

Thank you Robin!

robin-wang commented 3 years ago

@imarabbit Please let me know if you have any questions concerning switching branches to make this work. I also confirm that Angola2006-07 data should be ready for you as we speak.

Cheers!

jianingwwww commented 3 years ago

@imarabbit Please let me know if you have any questions concerning switching branches to make this work. I also confirm that Angola2006-07 data should be ready for you as we speak.

Cheers!

I have no doubts about switching branches but I'm not sure from which branch to which branch I should go when I pull requests. So I should create a new branch JIANING, and then pull requests from JIANING branch to the [SURVEY-NAME] branch, not from [SURVEY-NAME] branch to the MAIN branch (as I have done before), is that correct? Also, I have access to the data. Very thoughtful of you!