search

wernight / docker-plex-media-server

Dockerized Plex Media Server
https://registry.hub.docker.com/u/wernight/plex-media-server/
MIT License
128 stars 34 forks source link

Improve auto-update error #14

Closed wernight closed 8 years ago

wernight commented 8 years ago

If an error occurs during auto-update retrieval or install of Plex, show a clearly visible message inviting to do a docker pull wernight/plex-media-server:autoupdate or docker-compose pull.

JigSawFr commented 8 years ago

Not possible to do a fallback system ? (to latest public or known plex pass)

wernight commented 8 years ago

Good point.

Could wait for input if stdin is open or show a message for something like 30 sec if stdin is closed, and after skip the update part.

However if the user never installed it, it'd fail which I think is okay. The alternative would increase image size and some users may think it autoupdates when it fails due to their network or something.

JigSawFr commented 8 years ago

Or it could be great to force a link by an ENV var at run. For example, if it's crashing as actually, i can go to plex, copy link and force it in my run command, so container will be usable with last plex pass version. And we can wait for an updated image :)

wernight commented 8 years ago

Through environment sound hacky and edge case; like for people who really really cannot for to get latest version and have some decent system/programming knowledge, like you. ;)

JigSawFr commented 8 years ago

It will be invisible for end user, but available for us by putting 

-e PLEX_DL='https://downloads.plex.tv/plex-media-server/0.9.15.0.1621-344f193/plexmediaserver_0.9.15.0.1621-344f193_amd64.deb'

:)

wernight commented 8 years ago

Feel free to submit in PR. With the two new commits it should be pretty solid.

wernight commented 8 years ago

If you do, I'd recommend using explicit names like PLEX_FORCE_DOWNLOAD_URL and/or PLEX_SKIP_UPDATE.

wernight commented 8 years ago

Outside of those it should also show a clear error if username/password are wrong, see #13.

So summary: