weta-vn / advance_image_picker

Flutter plugin for selecting multiple images from the Android and iOS image library, taking new pictures with the camera, and edit them before using such as rotating, cropping, adding sticker/filters.
BSD 3-Clause "New" or "Revised" License
110 stars 49 forks source link

Several none breaking improvement proposals. #11

Closed rydmike closed 3 years ago

rydmike commented 3 years ago

Included updates

Suggestions for future improvements (not included here)

rydmike commented 3 years ago

By the way I just noticed the camera plugin by Flutter team just today got a spanking new version 0.9.0. We should probably try it out as well and upgrade to it too. Apparently the new plugin is an Android rewrite with many fixes. https://pub.dev/packages/camera/changelog

weta-vn commented 3 years ago

@rydmike Thank you very much about commit and a lot of improvement suggestions. We'll confirm & merge your commit into next release!

rydmike commented 3 years ago

Thanks @weta-vn for merging my pull request. I noticed you already tested camera 0.9.1, I just did as well and noticed it seemed to work OK and not have any compatibility issues.

I also noticed you are working on many other improvements, that you also just merged, nice work keep it up!

I will open another issue where we can discuss if you want to make a linting setup for this package, I can explain and demonstrate what is involved, unless you are already very familiar with Dart and Flutter linting of course, then I obviously don't need to explain it.

I really like this package that you have made, it composes existing native packages nicely for a use case with combined camera and photo library in the way it should be. Well it fits most of my my use cases very well. I have not seen any other good ones like it. I was thinking of writing one myself when I found this one. A friend and I are considering using your package in a small indie production side-project of ours.

I think this package has a lot of potential to become much more popular and generally used. If you want that, I could help you with it. I think it needs some additions on:

Are you on Twitter? We could talk more there in direct messages if you are interested. My Twitter handle is same as here @RydMike (https://twitter.com/RydMike).

Just some ideas for further collaboration if you are interested.

rydmike commented 3 years ago

Cool @weta-vn I just saw that you published a new version with the above pull and your own improvements, plus the new camera package - nice work, thanks! 👍🏻

The score also got up 10 points as I expected, plus it now has a bit more API doc comments too. Those are of course easy to improve further by adding more comments to public APIs. BTW the linter I suggested also detects where they are missing and can tell you about missing ones.

I compared the score and API doc coverage before and after this update, just out of curiosity 😃 : image

weta-vn commented 3 years ago

@rydmike Thank you very much. Sorry about late reply because we have urgent tasks in other project. We'll confirm your suggestion as soon as possible then discuss with you about improvement points. Of course, we want to make package better, and more people know and use it to make amazing apps. We're not on Twitter, but we'll join it soon. Thank you again.