search

weta-vn / advance_image_picker

Flutter plugin for selecting multiple images from the Android and iOS image library, taking new pictures with the camera, and edit them before using such as rotating, cropping, adding sticker/filters.
BSD 3-Clause "New" or "Revised" License
110 stars 49 forks source link

CRITICAL: filename case fix. Upper case does not build on Linux #16

Closed rydmike closed 3 years ago

rydmike commented 3 years ago

This is a critical bug fix

A friend of mine discovered that he cannot build a project with advance_image_picker included, since these two files are using uppercase in the filename, as show in diff below.

On a Linux/Chrome system these Flutter SDK files can then not be found when building the project, since they will be using lower case names as downloaded for the build and not upper case .Dart as shown below, which would be different files.

Yes, on Windows and macOS that do not use case sensitive file systems, the upper case names used in current code works.

This is a good example of why your lovely image picker really needs a linter, as I suggested and proposed here https://github.com/weta-vn/advance_image_picker/issues/15

There is actually a lint rule to detect and avoid this exact issue (https://dart-lang.github.io/linter/lints/file_names.html) and yes it is of course enabled in my suggestion too. 💙

weta-vn commented 3 years ago

@rydmike thank you very much. We'll confirm merge request asap, then release new version after test finished. About linter, we're consider to apply it to improve our code.