search

weta-vn / advance_image_picker

Flutter plugin for selecting multiple images from the Android and iOS image library, taking new pictures with the camera, and edit them before using such as rotating, cropping, adding sticker/filters.
BSD 3-Clause "New" or "Revised" License
110 stars 49 forks source link

Linters setup fix and lint rules review for Flutter 2.5 #23

Closed rydmike closed 2 years ago

rydmike commented 3 years ago

This pull request is discussed in detail in this issue https://github.com/weta-vn/advance_image_picker/issues/22

weta-vn commented 2 years ago

@rydmike Sorry about late reply. Thank you very much for your support.

rydmike commented 2 years ago

No problem @weta-vn, glad to help and I was not expecting any quick reply/action on a big PR like this, amazed that you merged it!

Did you fix also the linter warnings I still left in there on purpose? If not (I will check later myself) and if you need assistance with them, let me know and I can certainly take a look at them too. I just though it might be useful for you to evaluate them yourself before addressing them.

As always with linting rules, if some rule feels like it really gets in the way and does not fit your preferred style, just change or remove such opinionated lint rules to what you prefer 🙏🏻 😃