wevm / wagmi

React Hooks for Ethereum
https://wagmi.sh
MIT License
5.79k stars 968 forks source link

Fix issue in CLI where the Foundry & Hardhat exclude patterns were ignored #4112

Open allezxandre opened 4 days ago

allezxandre commented 4 days ago

The glob pattern forwarded to fdir was incorrect. It used: ["patternA", "!patternB", "!patternC"], which matches patternA, or anything that does not match patternB, or anything that does not match patternC. So when we were expecting to get anything that matches patternA, excluding patternB and patternC, it basically allowed any file (and ironically, the bigger the exclude list, the higher the probability of it including anything).

This PR solves that.

It should fix #4107, as well as older issues like #3752 and #1815.

changeset-bot[bot] commented 4 days ago

🦋 Changeset detected

Latest commit: ebafe3320ecd5cea0c9bcd765235d364937ae548

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | ---------- | ----- | | @wagmi/cli | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

vercel[bot] commented 4 days ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
wagmi ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 4, 2024 7:35am