search

whisklabs / docker-it-scala

Docker integration testing kit with Scala
MIT License
431 stars 91 forks source link

Plans to publish a jar with shaded spotify docker-client? #123

Closed nmeln closed 6 years ago

nmeln commented 6 years ago

https://github.com/spotify/docker-client provides shaded JAR which helps when you have Jersey 1.x in classpath, which is common with Hadoop dependencies.

I've just run into this issue. Tried excluding docker-client from docker-testkit-impl-spotify and adding its shaded jar separately, but keep getting ClassCastExceptions...

viktortnk commented 6 years ago

I would be happy if someone can help implementing this. Would be very useful

nmeln commented 6 years ago

I can try to implement this on weekend

nonsleepr commented 6 years ago

It should be as easy as substituting dependency:

-Seq("com.spotify" % "docker-client" % "8.11.5",
+Seq("com.spotify" % "docker-client" % "8.11.5" classifier "shaded",
viktortnk commented 6 years ago

I guess not everyone might want it shaded. I was more thinking of providing shaded version of docker-testkit itself

nonsleepr commented 6 years ago

You can do it as Spotify did: Publish two versions of the lib.

viktortnk commented 6 years ago

Spotify is using Maven. Can someone write it in SBT so that we publish with shaded classifier?..

nonsleepr commented 6 years ago

@viktortnk Any objections to the way I did it in #124?

nmeln commented 6 years ago

Has anybody looked at #124 ?