there is an issue with the implementation of DockerReadyChecker.and: it needs the implicit parameter ExecutionContext, but the default from DockerKit uses this.dockerContainers.length, which in turn needs all the containers (including ready checkers) to be configured. This results in a StackOverflowError.
Proposed solution: Implement DockerReadyChecker.and in terms of a combining class, something like
case class And(left: DockerReadyChecker, right: DockerReadyChecker) extends DockerReadyChecker { ... }
Hello folks,
there is an issue with the implementation of
DockerReadyChecker.and
: it needs the implicit parameterExecutionContext
, but the default fromDockerKit
usesthis.dockerContainers.length
, which in turn needs all the containers (including ready checkers) to be configured. This results in aStackOverflowError
.Proposed solution: Implement
DockerReadyChecker.and
in terms of a combining class, something likeCheers, Markus
P.S.: The same goes for
or
, naturally.