whisklabs / docker-it-scala

Docker integration testing kit with Scala
MIT License
430 stars 91 forks source link

DockerReadyChecker.and not implemented correctly #87

Closed burgerdev closed 7 years ago

burgerdev commented 7 years ago

Hello folks,

there is an issue with the implementation of DockerReadyChecker.and: it needs the implicit parameter ExecutionContext, but the default from DockerKit uses this.dockerContainers.length, which in turn needs all the containers (including ready checkers) to be configured. This results in a StackOverflowError.

Proposed solution: Implement DockerReadyChecker.and in terms of a combining class, something like

case class And(left: DockerReadyChecker, right: DockerReadyChecker) extends DockerReadyChecker { ... }

Cheers, Markus

P.S.: The same goes for or, naturally.

viktortnk commented 7 years ago

Thanks.That's a very good suggestion. #92 addresses it. Will release under 0.9.6

burgerdev commented 7 years ago

Nice, thanks!