search

whitequark / kicad-boardview

KiCAD to Boardview exporter reads KiCAD PCB layout files and writes ASCII Boardview files
BSD Zero Clause License
152 stars 23 forks source link

Corrected the skip_module function #14

Closed sabogalc closed 6 months ago

sabogalc commented 6 months ago

The skip_module function previously just searched if a module had the designator REF**. This did not work, but even if it did, it did not account for other miscellaneous modules that should be skipped, such as the NONO_HANA section in the screenshot below. I also faced issues with hold-down tabs that had HD** designators. As such, I rewrote the function to check if a component has zero pads, and if it has no pads, then the component is skipped. Screenshot 2024-03-03 033539 Screenshot 2024-03-03 033548

Less importantly, I updated README.md with images of the current version of Glasgow, but if you would like to have this omitted I understand. I'm not very well-versed in the etiquette of pull requests, so if these two changes should have been split into two separate pull requests, please let me know.

whitequark commented 6 months ago

I'm not very well-versed in the etiquette of pull requests, so if these two changes should have been split into two separate pull requests, please let me know.

Please submit them separately, yes.

sabogalc commented 6 months ago

Okay, this PR now only contains the fixed version of skip_module