whosonfirst / whosonfirst-www-spelunker

A simple Flask-based spelunker for poking around Who's On First data
BSD 3-Clause "New" or "Revised" License
7 stars 9 forks source link

Facet by language code(s) #105

Closed thisisaaronland closed 7 years ago

thisisaaronland commented 7 years ago

Specifically we want the ability filter for things with language x but also the ability to filter for things without language x.

So: We should keep a hard-coded list of languages that we want to "negate" by and then just add them, where appropriate, as UI elements (rather than ES results data).

This is blocked on:

I don't think we need to do any new or special indexing hoohah in: https://github.com/whosonfirst/py-mapzen-whosonfirst-search/blob/master/mapzen/whosonfirst/search/__init__.py

thisisaaronland commented 7 years ago

This is actually also blocked on:

https://github.com/whosonfirst/py-mapzen-whosonfirst-search/issues/26

nvkelso commented 7 years ago

Super cool, the == is working for me on prod :)

But =! (errr, !=) doesn't seem to work, I get a 500 error? I tried English, German, and a few others.

https://whosonfirst.mapzen.com/spelunker/id/102191575/descendants/?exclude=nullisland&translations=deu&translations=!eng

screen shot 2017-07-07 at 14 15 44
thisisaaronland commented 7 years ago

It's not supporting multiple translations correctly – I will file a separate ticket:

https://whosonfirst.dev.mapzen.com/spelunker/id/102191575/descendants/?exclude=nullisland&translations=!eng <-- works

thisisaaronland commented 7 years ago

Fixed.

nvkelso commented 7 years ago

Rad! (Didn't realize it was 2 levels of language deep!)