Fixes to JS config example

whosonfirst / whosonfirst-www-spelunker

A simple Flask-based spelunker for poking around Who's On First data

BSD 3-Clause "New" or "Revised" License

7 stars 9 forks source link

Fixes to JS config example #121

Closed mfogel closed 7 years ago

mfogel commented 7 years ago

Two fixes I had to make to get my local dev env working for #119. These changes are independent of #119, these just help the 'set up new dev env' process move a little smoother.

python env expects the 'data root' to not have a trailing slash, while the js env expects it Obviously there's other fixes possible here but this seemed like the least intrusive.
the function set_api_key doesn't exist anymore in mapzen.whosonfirst.leaflet.tangram.js, it's set_key, and it expects an API key with the mapzen- prefix

thisisaaronland commented 7 years ago

Thanks!

dphiffer commented 6 years ago

Heads up, @mfogel, I reverted part of the above commit in the part assigning the api_key: https://github.com/whosonfirst/whosonfirst-www-spelunker/pull/121/commits/296e25a00fbb88b9ee6308ca79c87f90b5ef8eba#diff-11a2a8fa42f9bbf195d0e64060fd72b4R42

This is mostly to support legacy keys that don't start with mapzen-. Another issue is the same config key gets used by both mapzen.whosonfirst.leaflet.tangram and the mapzen.whosonfirst.api. (I added a new comment warning about this.)

Thanks!