whosonfirst / whosonfirst-www-spelunker

A simple Flask-based spelunker for poking around Who's On First data
BSD 3-Clause "New" or "Revised" License
7 stars 9 forks source link

Vizualization of alternate geometries #124

Closed mfogel closed 3 years ago

mfogel commented 7 years ago

Addresses part of #119

This PR adds, for records that have alternate geometries, a selector widget under the map that allows the user to choose which geometry they'd like to see a visual of. Ex:

new-alt-geom-visualization-selector

For records that don't have alternate geometries, the behavior is unchanged.

I wasn't sure where exactly to put PR's for changes to two files: mapzen.whosonfirst.enmapify.js and mapzen.whosonfirst.leaflet.js. Both these files are present in whosonfirst/js-mapzen-whosonfirst, but only mapzen.whosonfirst.enmapify.js is pulled in by the Makefile. It appears there's been independent changes in both repos of these files so they're no longer in sync. As such, I've just put the changes here to start but let me know if it would be helpful if I open up another PR on whosonfirst/js-mapzen-whosonfirst.

This PR also pulls in whosonfirst/js-slippymap-crosshairs@bb40b2b as a consequence of updating slippymap-crosshairs to the latest in it's repo, these changes are technically outside the scope of this PR but AFIAK don't do any harm.