search

whosonfirst / whosonfirst-www-spelunker

A simple Flask-based spelunker for poking around Who's On First data
BSD 3-Clause "New" or "Revised" License
7 stars 9 forks source link

fix `src:lbl_centroid` field name typo #155

Open missinglink opened 1 year ago

missinglink commented 1 year ago

I noticed the label centroid src sometimes doesn't render correctly, this seems to be caused by a hard to catch typo src:lbl:centroid vs. src:lbl_centroid.

Screenshot 2023-09-06 at 19 56 29


Screenshot 2023-09-06 at 19 56 46

ref: https://github.com/whosonfirst/whosonfirst-properties/tree/main/properties/src

nvkelso commented 1 year ago

I've been confused by this, too! Thanks for proposing a fix :)

missinglink commented 1 year ago

This codebase has support for a property called src:centroid_lbl, is that still a thing @nvkelso ?

https://github.com/whosonfirst/whosonfirst-properties/blob/main/properties/src/centroid_lbl.json

nvkelso commented 1 year ago

Uff, one of those should be marked deprecated in the JSON metadata. @stepps00 do you remember the history here? It seems like we centralized on one of these only...