search

whosonfirst / whosonfirst-www-spelunker

A simple Flask-based spelunker for poking around Who's On First data
BSD 3-Clause "New" or "Revised" License
7 stars 9 forks source link

Spelunker Download feature #58

Closed dphiffer closed 7 years ago

dphiffer commented 7 years ago

This is a new Download feature for the Spelunker inspired by @burritojustice’s WOF Descender. It lets you download a bundle of WOF features, encoded as a GeoJSON FeatureCollection or as a CSV summary.

We started out calling it the Descender, but then switched it to "Bundler" to avoid confusion with the other project. And now I'm thinking we should just call it "Downloads" since that's how we labeled the links to it. To make things only slightly more confusing, I'm leaving the JavaScript library called mapzen.whosonfirst.bundler.js, which is designed to be reusable elsewhere.

The download feature lives at the path /download/[WOF id] and supports the URL argument ?include=[placetype] to support linking directly to a particular kind of descendant download. Example: https://localhost:8994/download/85977539/?include=borough (download boroughs of NYC)

You can find "download descendants" links: • From an individual WOF record (under Other, on the right sidebar) • Above the map on the Descendants results

nvkelso commented 7 years ago

@dphiffer neat! Can you include a few screenshots of what the dev feature looks like, please?

dphiffer commented 7 years ago

Screenshots!

screen shot 2016-12-02 at 12 56 26 pm screen shot 2016-12-02 at 12 56 45 pm

screen shot 2016-12-02 at 12 57 24 pm screen shot 2016-12-02 at 12 57 52 pm

dphiffer commented 7 years ago

Hmm two of those images aren't showing up. Do these work? screen shot 2016-12-02 at 12 57 24 pm screen shot 2016-12-02 at 12 57 52 pm

nvkelso commented 7 years ago

DUDE, this looks really good :)

On Fri, Dec 2, 2016 at 10:00 AM, Dan Phiffer notifications@github.com wrote:

Hmm two of those images aren't showing up. Do these work? [image: screen shot 2016-12-02 at 12 57 24 pm] https://cloud.githubusercontent.com/assets/38114/20844686/0fcd537c-b88f-11e6-876e-e6f289e98105.png [image: screen shot 2016-12-02 at 12 57 52 pm] https://cloud.githubusercontent.com/assets/38114/20844697/19c25756-b88f-11e6-841b-906985e1bc94.png

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/whosonfirst/whosonfirst-www-spelunker/pull/58#issuecomment-264519321, or mute the thread https://github.com/notifications/unsubscribe-auth/AA0EO0_mNYHxQ10BK4P_sqFY6dCkaNGVks5rEFy3gaJpZM4LCwF5 .

nvkelso commented 7 years ago

For a followup PR, it would be nice to see a Download link off the landing page for the Spelunker.

nvkelso commented 7 years ago

Also big thank you to @stepps00 for work in this PR.

thisisaaronland commented 7 years ago

I am going to close this PR without merging it because:

  1. There are/were merge conflicts
  2. It's been merged in to the dev-bundler branch (fixing the merge conflicts)
  3. There are some (minor) outstanding issues that need to be fixed before launching this – they are all tracked in Bundler milestone

Meanwhile this is enabled and otherwise working on the dev Spelunker. Yay!