search

whosonfirst / whosonfirst-www-spelunker

A simple Flask-based spelunker for poking around Who's On First data
BSD 3-Clause "New" or "Revised" License
7 stars 9 forks source link

save to gist #69

Closed burritojustice closed 7 years ago

burritojustice commented 7 years ago

would be super helpful to save the geojson bundle to gist (so we can more readily display it in Tangram)

https://developer.github.com/v3/gists/

a few libraries out there but haven't really dug in. but something that could offer to upload anonymously as well as with authentication might be handy?

http://fitzgen.github.io/github-api/ https://gist.github.com/isaacs/5375574

thisisaaronland commented 7 years ago

@burritojustice or @stepps00 – do either of you want to take a shot at a PR as a learning exercise? Feel free to unassign yourselves if not.

dphiffer commented 7 years ago

Hi @burritojustice, this is up on dev if you wanna test it out: https://whosonfirst.dev.mapzen.com/spelunker/download/102112179/?exclude=nullisland#14/37.7458/-122.4211

thisisaaronland commented 7 years ago

@burritojustice depending on when you read this I may or may not have merged the branch I am working on it to @dphiffer 's work. As of this writing dev is not running his code so if you try things and they don't work poke me and I toggle the relevant branches.

dphiffer commented 7 years ago

Here's a preview of what it looks like:

screen shot 2017-07-07 at 11 12 15 pm
nvkelso commented 7 years ago

Can the GIST functionality be a blue button instead of checkbox? (Or just the text link below the blue buttons?)

On Jul 7, 2017, at 08:14, Dan Phiffer notifications@github.com wrote:

Here's a preview of what it looks like:

― You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

dphiffer commented 7 years ago

Ok, this is back in action on dev.

@nvkelso why not both! Agree that the hyperlink doesn't sit very nicely next to those blue buttons, maybe that could be a blue button.

I like the checkbox here b/c it means you can do all the fussy parts and then you get just one long wait for the bundling to finish, then uploading to GitHub starts right after. If a button is what initiates the upload, you potentially have two coffee runs, since you gotta take action to keep the computers doing the computer stuff.

But that said, maybe two coffee runs are better than one?

stepps00 commented 7 years ago

I tested the "save to gist" functionality with microhoods in San Francisco and a neighbourhood in Portland - everything works as expected.

This is great!

dphiffer commented 7 years ago

Hey, that's good to hear!

I went ahead and changed the checkbox UI into a button. Thinking about it more I realized the flow just makes more sense as two distinct actions, even if it takes a little bit longer.