Make yesnofix a boolean config that doesn't break everything when it's not present

whosonfirst / whosonfirst-www-spelunker

A simple Flask-based spelunker for poking around Who's On First data

BSD 3-Clause "New" or "Revised" License

7 stars 9 forks source link

Make yesnofix a boolean config that doesn't break everything when it's not present #92

Open thisisaaronland opened 7 years ago

thisisaaronland commented 7 years ago

Make a config variable
Read / pass that config variable to base.html to enable the inclusion of CSS/JS
Don't break with errors like this when the CSS/JS is not present:

    2017-03-10T00:41:51.937Z error
    failed to format properties for ID 102543875, because TypeError: mapzen.whosonfirst.yesnofix is undefined

thisisaaronland commented 7 years ago

Parking this for now. The problem is that mz.wof.properties.js relies entirely on ynf.js for rendering stuff in to a pretty table. It would be nice to chunk out the rendering part of ynf in to a discrete library that could incorporate the yesnofix stuff but that smells like a yak, today...