search

wikimedia-france / Lingua-Libre

LinguaLibre – Massive Open Audio Recording system
http://v1.lingualibre.fr
GNU General Public License v3.0
14 stars 5 forks source link

Right-to-left abusive required="required" property-value makes it wrongly compulsory #63

Closed hugolpz closed 7 years ago

hugolpz commented 7 years ago

When creating a new language, the html form forced me to check "right-to-left" as true.

screenshot from 2017-08-10 14-52-59

Can someone make a fix ?

hugolpz commented 7 years ago

I think the bug comes from there.

screenshot from 2017-08-10 19-49-01

    ->add('description', TextareaType::class, array("required" => false))
    ->add('isRtl', CheckboxType::class)

Which we need to replace by : 

    ->add('description', TextareaType::class, array("required" => false))
    ->add('isRtl', CheckboxType::class, array("required" => false))
kamomil commented 7 years ago

Hi, Ill check it. I think the correct solution for that is actually to remove this checkbox and have a map between each language to direction.

kamomil commented 7 years ago

Hi, So your suggestion works ok, shall I push it?

hugolpz commented 7 years ago

I don't do php, i just inspected the html code and made logical deduction to find the needle in the github-hosted php code. It needs to be tested in dev mode by someone (you?) then pushed live on website by Nicolas.

hugolpz commented 7 years ago

@kamomil : I just saw your edit and push, thanks you :D I send the new to @zmoostik so this fix is deployed. :+1:

kamomil commented 7 years ago

cool :)

On Thu, Aug 17, 2017 at 7:04 PM, Lopez Hugo notifications@github.com wrote:

@kamomil https://github.com/kamomil : I just saw your edit and push, thanks you :D I send the new to @zmoostik https://github.com/zmoostik so this fix is deployed. 👍

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/wikimedia-france/Lingua-Libre/issues/63#issuecomment-323118436, or mute the thread https://github.com/notifications/unsubscribe-auth/AQGkxZ7m6lJlFZt8R_PnhaLQpgCf6ByUks5sZGSXgaJpZM4Oz2rp .