search

willforde / script.module.codequick

Kodi addon framework
GNU General Public License v2.0
33 stars 6 forks source link

Marking an item as watched doesn't do anything #19

Closed wwark closed 6 years ago

wwark commented 6 years ago

Hi @willforde I hope you are well.

If you play a video or mark as watched a video, the video still remain to status not watched. I tried with settings mediatype or not. It is a misconfiguration or an issue on Kodi or on codequick ? Thanks again for your help !

@SylvainCecchetto

willforde commented 6 years ago

I don't do anything with Watched flags. That should be all handled by Kodi. I will look into it and see if I can find out why it's not working.

willforde commented 6 years ago

I just tested it now and for me, Watched flags work on all my add-on's and your Catch-up TV add-on. Tested on Kodi v17.6 on Arch Linux.

wwark commented 6 years ago

Thank you for your tests so it means issue with Kodi 18 beta 5. I will test on Kodi 17.6 also.

willforde commented 6 years ago

I tested the watched flags on different add-on's on Kodi v18 and some work but others don't. The youtube add-on was one that did not work.

wwark commented 6 years ago

Do you think it maybe fix with that https://github.com/xbmc/xbmc/pull/14810 ? I will try on libreelec this evening because the last nightly include this fix.

wwark commented 6 years ago

I have test the last nightly the issue remain. I will file a Jira ticket to understand this behavior

willforde commented 6 years ago

Same for me, not working. But it is working for the youtube add-on now. I might be doing something that is conflicting and did some testing. I found that watched/unwatched worked when a Listitem is linking directly to a video, instead of redirecting back to the add-on to be resolved.

willforde commented 6 years ago

Found it. Kodi v18 don't like it when you use the path component of the add-on url, witch I was using for the route path. Now wether this is a bug with kodi or something that I should never have been doing in the first place, I don't know.

wwark commented 6 years ago

Thank you ! What is the impact to change to have listitem directly link to the video in codequick? Maybe it is better you to ask Kodi Team about that. What do you think?

willforde commented 6 years ago

A simple fix in the end, just needed to add a trailing /.

wwark commented 6 years ago

Thank you ! I will test the last version of codequick :) Have nice Sunday. Wwark

willforde commented 6 years ago

The fix is now available in the latest release in the Kodi repo.