williamkapke / node-compat-table

node.green - Node.js ECMAScript compatibility tables
https://node.green
Other
852 stars 32 forks source link

ssl? #43

Closed devsnek closed 6 years ago

devsnek commented 6 years ago

is there any reason the site doesn't have ssl? you should probably have ssl.

williamkapke commented 6 years ago

Just that GitHub doesn't offer it for custom domains. 👎

See long standing thread: https://github.com/isaacs/github/issues/156

devsnek commented 6 years ago

personally i use cloudflare to add ssl, which is free and also offers some nice caching, you should look into it

Krinkle commented 6 years ago

@devsnek +1 for HTTPS support, although caching would not help (might even slow things down) given the site is statically generated and hosted on GitHub Pages, which is already backed by GitHub's CDN.

devsnek commented 6 years ago

it wouldn't slow things down but it might give outdated information for a few minutes to hours after the site updates, but it isn't a feature you have to use

Krinkle commented 6 years ago

@devsnek I mean that on cache-miss, there is added latency from one CDN to the next. Adding a third caching layer, by itself, doesn't make much sense :-)

devsnek commented 6 years ago

https://blog.github.com/2018-05-01-github-pages-custom-domains-https/

devsnek commented 6 years ago

node.green is green now 🎉

williamkapke commented 6 years ago

WHOA... .... WHOA

I just read this and found out. What a great surprise to come home to!

ALSO: I've checked the Enforce HTTPS checkbox in the settings too!