wilsonzlin / minify-html

Extremely fast and smart HTML + JS + CSS minifier, available for Rust, Deno, Java, Node.js, Python, Ruby, and WASM
MIT License
842 stars 36 forks source link

Issue with HTML Minification Stripping type Attribute from button Tag #190

Open youappz opened 4 months ago

youappz commented 4 months ago

When running HTML minification, the type attribute of a button tag is being stripped off. Below is an example: in the above example button html tag after running html minify it strips of the type attribute

Original HTML:

<button aria-live="assertive" class="wpforms-submit" data-alt-text="Sending..." data-submit-text="Submit" id="wpforms-submit-6" name="wpforms[submit]" value="wpforms-submit" type="submit">Submit</button>```
</text>

Minified HTML

<button aria-live="assertive" class="wpforms-submit" data-alt-text="Sending..." data-submit-text="Submit" id="wpforms-submit-6" name="wpforms[submit]" value="wpforms-submit">Submit</button>

Minification Configuration

Using the following Rust code for HTML minification:

pub fn minify_html(html: &[u8]) -> Vec<u8> {
    let mut minify_cfg = minify_html::Cfg::spec_compliant();
    minify_cfg.minify_css = true; // temporary disable as its causing issues
    minify_cfg.minify_js = false; // causes issues with \\/ escaped urls in html
    minify_cfg.keep_closing_tags = true;
    minify_cfg.keep_input_type_text_attr = true;
    minify_html::minify(html, &minify_cfg)
}