windingwind / zotero-pdf-translate

Translate PDF, EPub, webpage, metadata, annotations, notes to the target language. Support 20+ translate services.
GNU Affero General Public License v3.0
6.15k stars 304 forks source link

[Feature] Modify Annotation Translation #92

Closed windingwind closed 2 years ago

windingwind commented 2 years ago

Yes, replace the original annotation text which highlighted will be better ,not add to comment area. False identification does not happen very often, but occasionally. If annotated citation text can be added from a area where they can be modified into the correct text, why not? 图片

Originally posted by @lil-i321 in https://github.com/windingwind/zotero-pdf-translate/issues/89#issuecomment-1099960421

windingwind commented 2 years ago

@lil-i321 try v0.6.6

lil-i321 commented 2 years ago

@lil-i321 try v0.6.6 for the latest version 0.7.4, the modified annotation translation can not add to the comment area.

windingwind commented 2 years ago

@lil-i321 It works fine for me. Could you please describe it in detail?

windingwind commented 2 years ago

Is the button missing, or it just doesn't work? If you click or select text in PDF after you translated an annotation, the modification will be disabled.

lil-i321 commented 2 years ago

@lil-i321 It works fine for me. Could you please describe it in detail?

step 1. select text in PDF . -> will display the wrong translation. step 2. correct the original annotation text in the translation panel and click the translate button -> will display the correct translation. step 3. highlight the text in PDF. -> original false identification and wrong translation will display in the comment area. in this step, I look forward to display the modified translation in the comment area.

lil-i321 commented 2 years ago

按键显示正常,就是这个功能不能实现,您可以随便找一篇pdf文献,先选中,再在翻译区修改原文,让译文发生改变,再点高亮,看看修改后的译文能否添加到注释区,以及注释区的原文是否是修改后的?

windingwind commented 2 years ago

image I still can't reproduce your problem

windingwind commented 2 years ago

在添加注释与修改之间,不要点击或选取pdf的文本;修改并更新侧边栏的翻译后,需要点击下方的更新注释按钮,方能更新到注释。这一操作与先前版本一致

lil-i321 commented 2 years ago

我这里没有 updata annotation 这个按钮啊 图片

windingwind commented 2 years ago

高亮某些文字,然后在右侧栏编辑文字,此时该按钮会出现。

lil-i321 commented 2 years ago

会的,需要在高亮文字后面新加文字,仅仅修改文字不改变高亮文字长度的情况下,不会出现

lil-i321 commented 2 years ago

即使如此,这个功能也非常令人满意了!!!非常感谢!!