windnode / WindNODE_ABW

Region Anhalt-Bitterfeld-Wittenberg
GNU Affero General Public License v3.0
3 stars 0 forks source link

Feature/#78 display notebooks in docs #187

Closed gplssm closed 3 years ago

gplssm commented 3 years ago

Fix #78 Fixes #157 Fixes #125

Updated docs https://windnode-abw.readthedocs.io/en/feature-78-display-notebooks-in-docs/

gplssm commented 3 years ago

I'm done so far! The final step would be to upload actual results notebooks to production instance of Zenodo (right now, sandbox.zenodo.org is used). I would do this, once we're happy with the presentation of results in general.

One question remains here: which timestamp should be used. Currently presented results come from 2020-08-18_101442_fixed. is this correct?

Further optional changes

gplssm commented 3 years ago

Thanks for the feedback!

Hey, thanks for the nice integration!

Some comments from my end:

1. Timestamp: The latest is `2020-08-20_003243` which is to be used

Ok, I'll re-run with this timestamp.

2. Scenario order: Instead of using `os.listdir()`, you could use the scenario CSV as you did in the scenario table (only if it can be quickly done). To prevent including non-existing files I'd keep the current list and use the CSV's column to reorder..

Yes! I'll do this. For the scenario table I simply take the order defined in scenarios.csv. I'll do the same here. But therefore, I need to complete #140 before

3. In the docs' NB ([example](https://windnode-abw.readthedocs.io/en/feature-78-display-notebooks-in-docs/notebooks/scenario_analysis_ISE_RE-_AUT80_DSM%2B_BAT%2B_PTH%2B.html#0_scenario_information)) the TOC links do not work.
gplssm commented 3 years ago

Discussion with @nailend. Todos for @gplssm

nesnoj commented 3 years ago

Thank you @gplssm !! :rocket: