search

wingsofovnia / seba-webappeng-team24

Feedback on employees gathering platform
MIT License
0 stars 0 forks source link

Implement missed entities with API, test and fix old API #65

Closed wingsofovnia closed 7 years ago

wingsofovnia commented 7 years ago

1

There is no registration/login API in users.js. It's a crud api for managing users. e.g. POST /users can be used by managers to create users, in manager console. These API should be protected by passport.

2

Model is done, API is done, what do we need else? Form - Matrix - MatrixCharacteristic and Feedback - Competencies are tow orthogonal, independent hierarchies. Form is a definition of a feedback form available for employees to leave feedbacks. The are made by MANAGERs and assigned to UserGroups so that when an employee X want to leave feedback on employee Y from usergroup Z, you will need to fetch a Form assigned to usergroup Z and show it to the employee X so he can leave fill out a correct matrix specialized for this usergroup Z. De facto, Form currently defines which Matrix should be used for usergroup X now. In "future" it can be extended with custom fields etc.

Feedback is an actual feedback left by an employee that contains a summary and filled out matrix (and filled out custom fields in "future"). Feedback's Competency is a grade/mark for specific MatrixCharacteristic. We cant merge them coz they are completely different things: MatrixCharacteristic is "you can evaluate my 'leadership' skills" while Competency says "your 'leadership' skills are 9/10".

P.S. I missed Form -> UserGroup binding. I'll add it in a moment.

ig0rsky commented 7 years ago

Is there an api regarding the request feedback use case? which method is run when I request feedback from user X Creating users from 'manager console' ? Dude how are we going to complete the project with this much complexity in 2 weeks? and also does that mean I can't just register with my e-mail? I have to have the manager create my account for me? I don't know man

wingsofovnia commented 7 years ago

Good point. I've just added this API 💯

Request feedback: POST /api/feedbacks/requests (for payload see README.md)

List feedback requests from user with username X: GET /api/feedbacks/requests?addresser=X

List feedback requests on user with username Y: GET /api/feedbacks/requests?username=X

List feedback requests on usergroup with userGroupname Z: GET /api/feedbacks/requests?userGroupname=Z