wintersleepAI / foundry-swnr

Stars Without Number: Revised for Foundry VTT
GNU Affero General Public License v3.0
32 stars 24 forks source link

Fix for TextEditor fields of item sheets not saving #31

Closed giuseppe-crea closed 1 year ago

giuseppe-crea commented 1 year ago

The root cause of this bug seems to be this overwrite. The API function it's overwriting returns an editor context, while this does not. As the overwrite seems to be doing absolutely nothing more than what the API function already does, the most immediate solution seems to be to simply delete it altogether.

I have given this a very limited test run, it does seem to fix the issue with item sheets (at least weapons, but they all inherit from here after all) and it doesn't seem to break anything, but please test it further before merging.

wintersleepAI commented 1 year ago

Thanks! I was poking around the same area, but trying to model after the 5e approach.

https://github.com/wintersleepAI/foundry-swnr/blob/v1-edit2/src/module/items/base-sheet.ts

Hope to get an update out soon with this fixed. Will try to test out your approach also!

wintersleepAI commented 1 year ago

manually merged!