I was exploring what it would cost to add the vendor directory to our
repository. After a vanilla dep ensure:
⌘ du -sh vendor
48M vendor
After running prune:
⌘ du -sh vendor
19M vendor
Before fixing this bug dep ensure would remove the unused
github.com/jteeuwen/go-bindata/go-bindata package, which would cause
subsequent builds to fail as:
⌘ dep prune
⌘ make
go install ./vendor/github.com/jteeuwen/go-bindata/go-bindata
can't load package: package github.com/ContextLogic/eventmaster/vendor/github.com/jteeuwen/go-bindata/go-bindata: cannot find package "github.com/ContextLogic/eventmaster/vendor/github.com/jteeuwen/go-bindata/go-bindata" in any of:
/usr/local/Cellar/go/1.9/libexec/src/github.com/ContextLogic/eventmaster/vendor/github.com/jteeuwen/go-bindata/go-bindata (from $GOROOT)
/Users/smcquay/src/github.com/ContextLogic/eventmaster/vendor/github.com/jteeuwen/go-bindata/go-bindata (from $GOPATH)
make: *** [/Users/smcquay/bin/go-bindata] Error 1
This change fixes that and allows us to prune the directory and still get
consistent builds.
I was exploring what it would cost to add the vendor directory to our repository. After a vanilla dep ensure:
After running prune:
Before fixing this bug dep ensure would remove the unused github.com/jteeuwen/go-bindata/go-bindata package, which would cause subsequent builds to fail as:
This change fixes that and allows us to prune the directory and still get consistent builds.