wizmer / syncorg

An implementation of MobileOrg for the Android platform
GNU General Public License v3.0
174 stars 23 forks source link

SyncOrg does empty commits when I open it #16

Closed fishman closed 7 years ago

fishman commented 8 years ago

I have the same as the guy in this picture

Commit changes to all files

chasecaleb commented 7 years ago

I can confirm this is an issue as well. I don't see any built in debug logging via the UI to submit, though.

ayyess commented 7 years ago

This could temporarily be fixed with something like

diff --git i/SyncOrg/src/main/java/com/coste/syncorg/synchronizers/JGitWrapper.java w/SyncOrg/src/main/java/com/coste/syncorg/synchronizers/JGitWrapper.java
index 1b8f83a..eb91931 100644
--- i/SyncOrg/src/main/java/com/coste/syncorg/synchronizers/JGitWrapper.java
+++ w/SyncOrg/src/main/java/com/coste/syncorg/synchronizers/JGitWrapper.java
@@ -430,6 +430,9 @@ public class JGitWrapper {
             Git git = null;
             try {
                 git = Git.open(repoDir);
+                if (git.status().call().isClean()) {
+                    return null;
+                }
                 // Stage all changed files, omitting new files, and commit with one command

 //                org.eclipse.jgit.api.Status status = git.status().call();
barryWarnock commented 7 years ago

This is still a problem on the android app

colonelpanic8 commented 7 years ago

Why was this closed. It seems like people are still having this issue?

wizmer commented 7 years ago

I fixed it yesterday.

Le mer. 25 janv. 2017 08:40, Ivan Malison notifications@github.com a écrit :

Why was this closed. It seems like people are still having this issue?

— You are receiving this because you modified the open/close state.

Reply to this email directly, view it on GitHub https://github.com/wizmer/syncorg/issues/16#issuecomment-275039871, or mute the thread https://github.com/notifications/unsubscribe-auth/ABm2VnG7HiyHTJfQc7k1RDZ24qwGgHMUks5rVvyCgaJpZM4KL3F6 .