wmde / mitmachen

Help new Wikipedia editors find articles with known issues
https://tools.wmflabs.org/mitmachen
GNU General Public License v2.0
2 stars 1 forks source link

DEV: The tool doesn't search within words or phrases #12

Closed darionewmonday closed 4 years ago

darionewmonday commented 5 years ago

Example: If I search nordrhein westfalen --> is found but if I search westfalen ---> is not found

If I search Motorsportfilm ---> is found but if I search sportfilm ---> is not found

dev-ckln commented 4 years ago

Now tool searches within words and phrases

ChristineDomgoergen commented 4 years ago

@dev-ckln I checked and it does not work yet. If I search for "Westfalen" I still don't get suggestions for "Nordrhein-Wesfalen". Could you check please?

dev-ckln commented 4 years ago

Please check now.

ChristineDomgoergen commented 4 years ago

@dev-ckln yes it works, but now the suggestions are sorted by alphabet. Is it possible to sort by relevance = the exactness of the matching of search term and suggested category? So for example when I search for Film, the first suggestion should be Film.

ChristineDomgoergen commented 4 years ago

@dev-ckln @darionewmonday Do you have an update on this? Without the sorting by relevance the search is not user friendly at all. This should be solved by tomorrow.

darionewmonday commented 4 years ago

@ChristineDomgoergen this is not considered as a bug. We can evaluate the effort and let you know if you want.

ChristineDomgoergen commented 4 years ago

@darionewmonday @dev-ckln Okay, but then this search feature is useless. Please do not search within words or phrases then just like it was before

darionewmonday commented 4 years ago

@ChristineDomgoergen actually no. The feature to search within words is really helpful, it´s the first thing I have noticed from the old tool. I mean, the relevance order of the results, is a different topic.

ChristineDomgoergen commented 4 years ago

@darionewmonday In general in other contexts this is a nice feature - in this case, because there are so many topic categories I think it is quite useless if we don't sort the search results by relevance. Try with "Film": now you don't get "Film" but alphabetically sorted suggestions for film from numbers to A (afganischer Film, albanischer Film...) -- because there are only the top 10 suggestions shown (which is a good thing). But the user can only get very specific results now, which seem quite random. I would definitely vote for not searching within words or phrases if we cannot do the sorting by relevance

darionewmonday commented 4 years ago

@dev-ckln what is the effort to revert the code?

ChristineDomgoergen commented 4 years ago

@darionewmonday @dev-ckln Do you have an answer to this yet?

darionewmonday commented 4 years ago

The code has been reverted as per your request.

Correct @dev-ckln ?

dev-ckln commented 4 years ago

@darionewmonday The code has not been reverted yet, will do soon.

dev-ckln commented 4 years ago

@darionewmonday The code is reverted

ChristineDomgoergen commented 4 years ago

@darionewmonday @dev-ckln I don't see a change here, the search is still searching within words or phrases? Could you estimate the effort it would take to sort the results by relevance? Thank you.

dev-ckln commented 4 years ago

@ChristineDomgoergen I'll take a look at it again as I've already reverted the code, it should work. To answer your question for relevance - There is no relevance measure available, so its not possible to do so.

ChristineDomgoergen commented 4 years ago

@dev-ckln @darionewmonday In this case relevance means how well the result matches the search term.

darionewmonday commented 4 years ago

@ChristineDomgoergen can you be more specific? What do you expect here to happen?

ChristineDomgoergen commented 4 years ago

@darionewmonday So one example would be: I search for Film 1st result should be Film (100% matching result and search term) 2nd result could be for example Filmwissenschaft or Filmstar or 3D-Film (less than 100% matching but still very close) next results could be Verfilmung or Affe im Film oder Afghanischer Film (not so close to Film anymore, quite specific results)

It is like the sorting search results in any online search: first results should be the most relevant results for the user. Do you know what I mean?

dev-ckln commented 4 years ago

@ChristineDomgoergen @darionewmonday Please review, its done as per reverted code

ChristineDomgoergen commented 4 years ago

@dev-ckln Code works now reverted thank you. The other question is still open though...

darionewmonday commented 4 years ago

@ChristineDomgoergen yes we know what you mean but we have reverted the code to the original version. It means, when you need any change or functionality here, it´s a change request. Otherwise, the ticket can be closed.

ChristineDomgoergen commented 4 years ago

@darionewmonday yes, that is fine. Could you estimate the effort for the change request?

darionewmonday commented 4 years ago

@ChristineDomgoergen sure. Can you please create a different ticket and close this one?