wmde / mitmachen

Help new Wikipedia editors find articles with known issues
https://tools.wmflabs.org/mitmachen
GNU General Public License v2.0
2 stars 1 forks source link

Task filter does not filter new searches via search bar #47

Closed ChristineDomgoergen closed 4 years ago

ChristineDomgoergen commented 5 years ago

@dev-ckln Hi Deepak, the task filter does not filter new searches:

I selected two types of tasks in the task filter I entered a search term in the search bar (e.g. Gedicht) I clicked return I got results including all types of tasks

I expected to see only results for the selected types of tasks

Could you please check?

dev-ckln commented 5 years ago

@darionewmonday It is done

ChristineDomgoergen commented 5 years ago

@dev-ckln @darionewmonday Thank you, looks better now. Like in Issue 41 the message I get needs to be updated because right now it only refers to the type of task "1 Artikel gefunden in Lückenhaft" but should still refer to the search term as well "1 Artikel gefunden in Gedicht und Lückenhaft"

dev-ckln commented 5 years ago

@darionewmonday @ChristineDomgoergen Please check it is done

ChristineDomgoergen commented 5 years ago

@dev-ckln Again as in already commented #41 for the message it is If all tasks are selected --> message should not list all tasks but only show search term / category if less than all tasks are selected (the task filter is active) --> message should indicate search term / category and types of selected tasks

dev-ckln commented 5 years ago

It is done @ChristineDomgoergen @darionewmonday

ChristineDomgoergen commented 4 years ago

@dev-ckln HI Deepak, almost good now, I just found another bug though: I search via search bar or select interests I get results I change the task filter and deselect a random task --> message is fine, all good I change the task filter again to show all tasks --> message lists search term, all tasks and is doubled (see screenshot)

can you please check? Thank you. Screenshot_2019-11-14 Mitmachen in Articles Screenshot_2019-11-14 Mitmachen in Articles(1)

dev-ckln commented 4 years ago

@ChristineDomgoergen @darionewmonday It is done

ChristineDomgoergen commented 4 years ago

@dev-ckln @darionewmonday I can still replicate it (see screenshot). The problem is the message: Screenshot_2019-11-18 Mitmachen in Articles

dev-ckln commented 4 years ago

@ChristineDomgoergen It is fixed.

ChristineDomgoergen commented 4 years ago

@dev-ckln Perfect, thank you