search

wmde / mitmachen

Help new Wikipedia editors find articles with known issues
https://tools.wmflabs.org/mitmachen
GNU General Public License v2.0
2 stars 1 forks source link

Show category-selection / update-button above the fold (without scrolling) #48

Closed ghost closed 5 years ago

ghost commented 5 years ago

As user I want to see the "update"-button when selecting desired categories In order to not asking myself "what now" after having selected them.

-> currently, for large screens/desktop-pc's, the "update" button is out of sight / below the fold

image

(there seems to be a breakpoint at 1200px which introduces some space above the selection pop-up, causing the update-button to disappear)

dev-ckln commented 5 years ago

@LukasWMDE If you need pop-up without scroll then we need to optimise little design changes like decrease the height of boxes with updating some spaces. With new design optimisations the pop up will look like this. Please check and confirm. image

darionewmonday commented 5 years ago

It looks better with squared boxes. A solution can be to move the button on top of the squares rather than leaving it below.

Il ven 25 ott 2019, 10:30 Deepak notifications@github.com ha scritto:

@LukasWMDE https://github.com/LukasWMDE If you need pop-up without scroll then we need to optimise little design changes like decrease the height of boxes with updating some spaces. With new design optimisations the pop up will look like this. Please check and confirm. [image: image] https://user-images.githubusercontent.com/48859836/67579381-012b9580-f762-11e9-892b-832a9dce55b8.png

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/wmde/mitmachen/issues/48?email_source=notifications&email_token=AM3ICHBCSMXVURVGNUKKY3DQQL7GVA5CNFSM4JEUU4W2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECIQ62I#issuecomment-546377577, or unsubscribe https://github.com/notifications/unsubscribe-auth/AM3ICHHTBP43ZZLKFXHTU4DQQL7GVANCNFSM4JEUU4WQ .

ghost commented 5 years ago

I see 3 options:

@ChristineDomgoergen what is your opinion?

darionewmonday commented 5 years ago

Hi everyone,

I suggest to go for the low hanging fruit option (number 3) since basically everything is feasible but listed under change request, meaning we have to calculate a budget for the change.

Nevertheless, to move a button is not a big deal.

Thanks!

Il lun 28 ott 2019, 02:56 LukasWMDE notifications@github.com ha scritto:

I see 3 options:

  • reduce space above pop-up for screens above 1200 px (@dev-ckln https://github.com/dev-ckln , could you please comment on feasability? This would keep the pop-up the way it is, just move it a little higher)
  • reduce height of tiles (my 2nd choice: I actually kind of like the rectangular tiles)
  • move update-button on top (my 3rd choice: would lead either to differences between mobile and desktop or reduce mobile usability, if you keep the update-button on top in mobile; also, the pop-up would still end below the fold)

@ChristineDomgoergen https://github.com/ChristineDomgoergen what is your opinion?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/wmde/mitmachen/issues/48?email_source=notifications&email_token=AM3ICHEADGI66IQHLN6SPPLQQ2EJBA5CNFSM4JEUU4W2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECL37XQ#issuecomment-546815966, or unsubscribe https://github.com/notifications/unsubscribe-auth/AM3ICHBS6WKC4KC3GBQDEZ3QQ2EJBANCNFSM4JEUU4WQ .

darionewmonday commented 5 years ago

@dev-ckln please move the button up, top-right corner.

dev-ckln commented 5 years ago

@darionewmonday It is done. I have updated it for tablet and larger than tablet screen sizes

ChristineDomgoergen commented 5 years ago

@dev-ckln great, thank you!