search

wmde / mitmachen

Help new Wikipedia editors find articles with known issues
https://tools.wmflabs.org/mitmachen
GNU General Public License v2.0
2 stars 1 forks source link

Bug: Filter by Task autmatically set on "no selection" #51

Closed ChristineDomgoergen closed 4 years ago

ChristineDomgoergen commented 4 years ago

@dev-ckln @darionewmonday The task filter is per default set on no tasks selected, when I change the selection of my interests.

This is what happens: --> I select my interests and find articles as usual --> all good --> I click on Auswahl ändern and change the selection in the Pop-Up (which is not translated yet!) --> I find 0 articles.

I checked and it is not because there are not articles but because in the task filter there is no type of tasks selected --> please fix: per default all types of task should be selected

Edit: this happens also when I start via search bar and then change to my interests, even if I had no interests preselected. --> seems to be ocurring always after the pop-up was shown

dev-ckln commented 4 years ago

@ChristineDomgoergen @darionewmonday I could find it working.. Please share screenshots for detailed explanation!

ChristineDomgoergen commented 4 years ago

@dev-ckln Hi Deepak, please find a screenshot attached. Screenshot_2019-11-01 Mitmachen in Articles(4)

dev-ckln commented 4 years ago

@ChristineDomgoergen @darionewmonday Can you please check again, I am not able to replicate the same

ChristineDomgoergen commented 4 years ago

@dev-ckln yes correct, now it seems to work. Perfect :-)

ChristineDomgoergen commented 4 years ago

Hi @dev-ckln @darionewmonday, now the bug seems to be there again: always when I change the task selection and then click on "favourite topics" the task filter is set on no selection and there are 0 results shown. Can you please check again? Thank you.

darionewmonday commented 4 years ago

@ChristineDomgoergen this is not a bug.

The behaviour of the filter on the right is simply to filter after the results are shown.

WHEN The results are displayed THEN the user can filter the results

WHEN the user changes page THAN We need first to show results AND then the user can filter again

Same thing happens when the user searches after the filtering. The filters reset, then we display results, then the user can filter again.

Like Zalando, Amazon, etc

Correct @dev-ckln ?

dev-ckln commented 4 years ago

@darionewmonday When new results are loaded then filters are kept the same, after loading results we automatically apply the existing filters.

ChristineDomgoergen commented 4 years ago

Yes, that totally makes sense. But please check if you can reproduce the bug, because in this case the filter is automatically switches from ALL TASKS selected to NO TASKS selected, without the user applying any changes...

darionewmonday commented 4 years ago

@dev-ckln pls check

dev-ckln commented 4 years ago

@darionewmonday @ChristineDomgoergen It is done

ChristineDomgoergen commented 4 years ago

@dev-ckln great, thank you.