wmde / mitmachen

Help new Wikipedia editors find articles with known issues
https://tools.wmflabs.org/mitmachen
GNU General Public License v2.0
2 stars 1 forks source link

No interest pop-up when clicked on my interests #54

Closed ChristineDomgoergen closed 5 years ago

ChristineDomgoergen commented 5 years ago

@darionewmonday @dev-ckln When I click on my interests afterthe tool now reloads the topics: --> i select interests and click on update --> i see article results --> i click on my interests again --> for a second the old transition page appears (with the "Interessen bearbeiten" button) and then the categories (topics) are reloaded and new results are shown

I would expect instead to open the selection pop-up.

darionewmonday commented 5 years ago

@ChristineDomgoergen let us check.

The popup should open only in 2 cases: 1) Automatically, when the user hasn´t picked any interest yet and I open "my interests page" 2) When I click "update interests"

dev-ckln commented 5 years ago

@darionewmonday It is working as per the requirements you shared

ChristineDomgoergen commented 5 years ago

@darionewmonday @dev-ckln yes, this is fine, thanks for implementing. But before this change the pop-up also opened when you clicked on "my interests", respectively there was the intermediary page with the "edit interests" button, right? Now we do not have this page any more, which adds one case. So we have three cases:

  1. see above
  2. see above
  3. when I click "my interests"
dev-ckln commented 5 years ago

@darionewmonday @ChristineDomgoergen Please confirm. Now the popup will open in these three cases:

  1. Automatically, when the user hasn´t picked any interest yet and I open "my interests page"
  2. When I click "update interests"
  3. when I click "my interests"

Please provide an explanation!

darionewmonday commented 5 years ago

@dev-ckln I have just double-tested it and the way it works right now looks 100% correct. can you confirm @ChristineDomgoergen ?

ChristineDomgoergen commented 5 years ago

@darionewmonday @dev-ckln No for me it does not work if I am on page 2 and then click my interests there is no pop-up shown but the categories are reloaded

darionewmonday commented 5 years ago

@ChristineDomgoergen I can see articles and categories reloading when I go back-forth to Deine Themen, but the popup should not open. It should only open when I click on "Auswahl ändern".

Or are not understanding what you wish to have?

ChristineDomgoergen commented 5 years ago

@darionewmonday yes I guess there is a misunderstanding. As a user I do not want the articles and categories to reload when I click on my interests. When I want to reload I will click reload categories. When I click on my interests I want to edit my interests. Therefore the pop-up should open. Do you understand what I mean?

Also I always see for a second the previous intermediary page, where you could click on the button edit interests before new articles are shown. Too fast for a screenshot, sorry. This should not happen.

darionewmonday commented 5 years ago

@dev-ckln

1) Remove the automatic reload of categories 2) Remove the split-second old screen from appearing on the loading of the page

thanks

dev-ckln commented 5 years ago

@darionewmonday @ChristineDomgoergen It is done. Please check

ChristineDomgoergen commented 5 years ago

@dev-ckln Okay, the split second screen is not there anymore, thank you. But I don't understand @darionewmonday: now nothing happens, when I click on my interests - although it is a button? What is the idea behind this? Why does the pop-up for interest selection not open?

darionewmonday commented 5 years ago

@ChristineDomgoergen the pop-up opens not when I click on "Your interests" but when I come to "my interests" page and there are no results to be shown because I have not selected any interest.

IF User comes to Your interests page AND No results can be shown because no interests have been selected THEN open pop up ELSE Open pop-up only when I click on "Edit interests"

dev-ckln commented 5 years ago

@ChristineDomgoergen @darionewmonday It is done. Please check and close or let me know if any revisions required!