wmde / mitmachen

Help new Wikipedia editors find articles with known issues
https://tools.wmflabs.org/mitmachen
GNU General Public License v2.0
2 stars 1 forks source link

Bug: previous interest selection shown but not included in search #55

Closed ChristineDomgoergen closed 5 years ago

ChristineDomgoergen commented 5 years ago

--> I refresh the page or go back to the main page (e.g. via the Logo in the top menue) --> the previously selected interests are still shown and marked green --> I click on update --> I get a message: no results found --> I go back to my interests and there are no interests preselected anymore

--> I would instead expect to get results for the preselected interests

dev-ckln commented 5 years ago

@ChristineDomgoergen @darionewmonday This is something that was deliberately made to change. We are clearing localstorage upon refresh.

ChristineDomgoergen commented 5 years ago

@dev-ckln yes this is also a good solution, clear localstorage. But then we also want the preselection of my interests to be cleared. Right now, when I refresh my previous selection is still shown (dark green tiles)

dev-ckln commented 5 years ago

@darionewmonday @ChristineDomgoergen It is done. Please check

ChristineDomgoergen commented 5 years ago

@dev-ckln Yes it now works when I go back to home via Wikipedia Logo. But now I have a bug in the interest selection and message about interests:

--> I selected Geografie and clicked on find articles --> results for more interests than geografie were shown (see screenshot for selection provided by tool) --> also the message indicating which interests are selected does not count correctly (sometimes it says +11 more, but there are only 8 in total) Screenshot_2019-11-01 Mitmachen in Articles(7) Screenshot_2019-11-01 Mitmachen in Articles(6)

dev-ckln commented 5 years ago

@ChristineDomgoergen @darionewmonday It is done. Please check

ChristineDomgoergen commented 5 years ago

@dev-ckln great, thank you!