woocommerce / woocommerce-gateway-paypal-express-checkout

59 stars 64 forks source link

Single Product Button Settings does not have `Hide Funding Method(s)` field. #767

Closed htdat closed 4 years ago

htdat commented 4 years ago

Describe the bug

Customers want to hide Debit or Credit Card black button in single product pages but there is no option to choose.

To reproduce

  1. Go to PayPal Checkout settings page
  2. Select Checkout on Single Product option
  3. Field Hide Funding Method(s) does not display.
  4. Debit or Credit Card buttons are still there in single product pages.

Screenshots

Screen Shot on 2020-06-11 at 13:06:54

Expected behavior

Environment (please complete the following information):

Additional details

3024064-zen 3015417-zen

System status ``` ```
Areahints commented 4 years ago

I'm having similar problems, see issue #527

it's happening on a production site so I've had to use another plugin.

jorgeatorres commented 4 years ago

Hi @htdat!

Thanks for the report. "Hide Funding Method(s)" is only shown when "Button Layout" is set to "Vertical". That is, the horizontal layout doesn't support choosing which payment options to show/hide. Is that not working correctly here?

mattallan commented 4 years ago

We have an open PR to address this, see https://github.com/woocommerce/woocommerce-gateway-paypal-express-checkout/pull/758

tl;dr with the new PayPal SDK, the Debit card options are now being displayed on Horizontal layout and we have no option/setting for store managers to hide it (because we only show the Hide Funding Methods field on Vertical layout)

The PR I added makes sure we manually hide the Cards button on Horizontal layout

jorgeatorres commented 4 years ago

Now that #774 has been merged, the Cards button should be hidden on the "Horizontal" layout (pending release). As for "Hide Funding Method(s)" not being present under "Single Product Button Settings", as explained it's due to the layout not being set to "Vertical", which is the one layout allowing methods to be hidden.