Hide "Pay Later" funding method when "Credit" is disabled

[jorgeatorres]

Description

Pay Pal is rolling out a "Pay Later" button to replace the current "PayPal Credit" button. This change is already available in sandbox mode and will make it to the live environment soon.

This PR updates our code so that hiding "Credit" as a funding source results in "Pay Later" being hidden too. It also simplifies some of the code dealing with Credit in WC_Gateway_PPEC_Cart_Handler::get_button_settings().

Steps to test:

1. Check out trunk.
2. Go to WC > Settings > Payments > PayPal Checkout.
3. Uncheck all context specific settings toggles ("Configure settings specific to …"). This is not required but helps as you'd only need to test one set of settings.
4. Make sure your setup is compatible with PayPal Credit and that it is enabled:
   1. Store address must be in the US.
   2. You should be browsing from the US either by using a VPN or a snippet like this one:

      add_filter( 'woocommerce_paypal_express_checkout_sdk_script_args', function( $settings ) {
      $settings['buyer-country'] = 'US';
      return $settings;
      } );

   3. If your button is using the vertical layout, Credit should not be a hidden funding method. If the layout is horizontal, the "Enable PayPal Credit to eligible customers" must be checked.
5. Go to the frontend (single product page, cart or checkout) and make sure you see the "Pay Later" button.
6. Disable the Credit button: do the opposite of 4-iii.
7. Go to the frontend and make sure you still see the "Pay Later" button. This is wrong but it's what this PR is fixing.
8. Check out this branch (paylater).
9. Make sure the "Pay Later" button no longer appears.
10. Toggle the Credit settings again (depending on layout) to re-enable Credit and make sure the "Pay Later" button appears.
11. Repeat the above with a different button layout.
12. Optionally, re-enable context specific settings and try a few combinations.

Documentation

We might need to update screenshots referring to "PayPal Credit".

Changelog entry

Enter a summary of all changes on this Pull Request. This will appear in the changelog if accepted.

Hide "Pay Later" funding method when "Credit" is disabled.

[mattallan]

Nice work @jorgeatorres and thanks for the clear testing instructions!!

My checkout is still showing the Pay Later button even though I'm hiding the PayPal Credit option in my PPEC Settings :(

---

I found the issue is that it doesn't like my disallowed_methods array keys going from [0] to [2] and it seems we need to reindex/reorder the array:

[disallowed_methods] => Array
        (
            [0] => CREDIT
            [2] => PAYLATER
        )

This is being caused by the array_unique and array_merge i assume:

$hide_funding_methods = $settings->{ $prefix . 'hide_funding_methods' };
$hide_funding_methods = is_array( $hide_funding_methods ) ? $hide_funding_methods : array();

$data['disallowed_methods'] = array_unique(
    array_merge(
        $hide_funding_methods,
        ( ! $credit_supported || in_array( 'CREDIT', $hide_funding_methods, true ) ) ? array( 'CREDIT', 'PAYLATER' ) : array()
    )
);

[jorgeatorres]

Hi @mattallan!

Thanks for reviewing. You're absolutely right, it's because the array is no longer indexed sequentially and so wp_localize_script() turns it into a regular object instead. I've pushed some code to make sure it's an array on the PHP side but also make sure our function on the JS side is more robust and can work with objects, just in case.

Let me know what you think!

[mattallan]

I like it! Much nicer fix than what I was thinking :) (I didn't see the foreach loop using $i++ in JS)

LGTM :100: