jorgeatorres
commented
3 years ago Code analysis
- [x] No 'obvious' syntax errors:
# Run with PHP 8 in the PATH or replace php by the correct binary. find . \( -path ./tmp -o -path ./tests -o -path ./vendor \) -prune -o \( -name '*.php' \) -exec php -lf {} \; - [x] PHPCS + PHPCompatibility:
phpcs -p . --standard=PHPCompatibility --runtime-set testVersion 8.0 - [x] ⚠️
call_user_func_array()array keys will now be interpreted as parameter names, instead of being silently ignored.- [x] Check usage of
do_action_ref_array(). - [x] Check usage of
apply_filters_ref_array().
- [x] Check usage of
-
[x] ⚠️ Non-strict comparisons between numbers and non-numeric strings now work by casting the number to string and comparing the strings. Comparisons between numbers and numeric strings continue to work as before.
Example:
0 == 'astring'now evaluates tofalse. - [x] ⚠️ Inheritance errors due to incompatible method signatures (LSP violations) will now always generate a fatal error.
- [x] Calling
implode()with parameters in a reverse order($pieces, $glue)is no longer supported. - [x]
parse_str()can no longer be used without specifying a result array. - [x] The needle argument of
strpos(),strrpos(),stripos(),strripos(),strstr(),strchr(),strrchr(), andstristr()will now always be interpreted as a string. Previously non-string needles were interpreted as an ASCII code point. - [x]
matchis now a reserved keyword. - [x]
parse_url()will now distinguish absent and empty queries and fragments - [x] The result of sorting functions may have changed, if the array contains elements that compare as equal.
- [x] Sort comparison functions that return
trueorfalseshould be replaced with an implementation that returns an integer less than, equal to, or greater than zero. - [x]
substr(),mb_substr(),iconv_substr()andgrapheme_substr()now consistently clamp out-of-bounds offsets to the string boundary. Previously, false was returned instead of the empty string in some cases. - [x] Declaring a required parameter after an optional one is deprecated.
- [x] Removed ability to call non-static methods statically.
- [x] Removed ability to use
array_key_exists()with objects. - [x] The
@operator will no longer silence fatal errors. - [x]
mktime()andgmmktime()now require at least one argument. - [x]
openssl_x509_read()andopenssl_csr_sign()will now return anOpenSSLCertificateobject rather than a resource. Return value checks usingis_resource()should be replaced with checks forfalse. - [x] A number of warnings have been converted into Error exceptions:
- [x] Attempting to write to a property of a non-object. Previously this implicitly created an
stdClassobject fornull,falseand empty strings. - [x] Attempting to append an element to an array for which the
PHP_INT_MAXkey is already used. - [x] Attempting to use an invalid type (array or object) as an array key or string offset.
- [x] Attempting to write to an array index of a scalar value.
- [x] Attempting to unpack a non-array/Traversable.
- [x] Attempting to write to a property of a non-object. Previously this implicitly created an
- [x] A number of notices have been converted into warnings:
- [x] Attempting to read an undefined variable.
- [x] Attempting to read an undefined property.
- [x] Attempting to read an undefined array key.
- [x] Attempting to read a property of a non-object.
- [x] Attempting to access an array index of a non-array.
- [x] Attempting to convert an array to string.
- [x] Attempting to use a resource as an array key.
- [x] Attempting to use null, a boolean, or a float as a string offset.
- [x] Attempting to read an out-of-bounds string offset.
- [x] Attempting to assign an empty string to a string offset.
- [x] Compile time fatal error "Only variables can be passed by reference" has been delayed until runtime and converted to "Argument cannot be passed by reference" exception.
- [x] Float to string casting will now always behave locale-independently.
- [x] Nested ternaries now require explicit parentheses.
- [x] Magic Methods will now have their arguments and return types checked if they have them declared. The signatures should match the following list:
__call(string $name, array $arguments): mixed__callStatic(string $name, array $arguments): mixed__clone(): void__debugInfo(): ?array__get(string $name): mixed__invoke(mixed $arguments): mixed__isset(string $name): bool__serialize(): array__set(string $name, mixed $value): void__set_state(array $properties): object__sleep(): array__unserialize(array $data): void__unset(string $name): void__wakeup(): void
PHP 8.0 is planned for November 26th. We need to test and make sure the plugin works with this version.
See https://github.com/php/php-src/blob/107962208a19d8b6dc1a190cb25fc37614411e71/UPGRADING.