search

woocommerce / woocommerce-gateway-paypal-express-checkout

58 stars 65 forks source link

Upgrade to PayPal Payments Notice on Plugins Page #866

Closed achyuthajoy closed 3 years ago

achyuthajoy commented 3 years ago

Description

As part of various efforts to drive adoption of PayPal Payments, this PR aims to add a notice on the WordPress plugins page suggesting users to upgrade from PayPal Checkout to PayPal Payments.

Screenshot of the notice

Screenshot

Screencast - https://d.pr/v/Y24RUS

Steps to test:

  1. Checkout the branch paypal-payments-upgrade-notice & activate the plugin if not active.
  2. On the installed plugins page, a new section is added just below PayPal Checkout suggesting upgrade to PayPal Payments.

The SCSS code used can be found here - https://gist.github.com/achyuthajoy/06a2012495d2d2816678fe15e9860c05

Changelog entry

Enter a summary of all changes on this Pull Request. This will appear in the changelog if accepted.

Adds notice on plugins page to upgrade to PayPal Payments.

achyuthajoy commented 3 years ago

@jorgeatorres Not sure why Travis is failing. The error doesn't come up when I'm running PHPCS locally with php@7.4. Travis is running php@7.0

achyuthajoy commented 3 years ago

The same error showed up locally when I switched to php@7.0. But there is no error with the code. Weird.

achyuthajoy commented 3 years ago

@jorgeatorres The error with php@7.0 is fixed now. All good.

achyuthajoy commented 3 years ago

It feels odd to me that once a merchant has both installed and activated PayPal Payments, we're still telling them about the upgrade to PayPal Payments in a very hard to miss notice (despite the fact that they've already read and acted on our messaging).

Couldn't we reduce the messaging somehow when PayPal Payments is already installed and active? If not, that's ok, but maybe we could hide the "Learn More" button or make the "Configure PayPal Payments now" a secondary button (like "Learn More" itself) and relabel as "Configure PayPal Payments" or something similar. The combination of the button being a primary button and the "Configure PayPal Payments now" label makes it look as if I (as a merchant) have missed something and still need to setup PayPal Payments, which is probably not the case.

@LevinMedia Can you look into this and suggest options?

LevinMedia commented 3 years ago

@achyuthajoy I agree, once PayPal Payments is installed, I don't think we should show any additional messaging in the express checkout gateway plugin. Rather we should focus our efforts on making the onboarding to PayPal Payments as easy as possible through that extension.

Therefore, we can delete this message once PayPal Payments is installed.

achyuthajoy commented 3 years ago

Thanks @LevinMedia. I'll remove the message once the plugin is installed & configured.

LevinMedia commented 3 years ago

@achyuthajoy Just to be clear - I think we can remove the message as soon as the new gateway is installed, before it's configured. We should rely on the new gateway to drive the configuration process :)

achyuthajoy commented 3 years ago

Sure @LevinMedia. I'll make the change. 😄

achyuthajoy commented 3 years ago

@jorgeatorres The requested changes are updated. Couple of new changes based on https://github.com/woocommerce/woocommerce-gateway-paypal-express-checkout/pull/866#issuecomment-860837916

  1. Notice would be hidden if PayPal Payments is installed and active
  2. Configure PayPal Payments now button removed

I've also updated the PR testing instructions to remove Configure PayPal Payments now.