search

woodruffw / screenfetch-c

A rewrite of screenFetch in C.
MIT License
73 stars 17 forks source link

fix OSX 10.10 build #16

Closed sariyamelody closed 9 years ago

sariyamelody commented 9 years ago

I'm pretty sure this isn't the correct style for this project, but it is a PoC of the fix required. It might be preferable to make distro_name_distro_str and distro_name_str local variables in detect_distro.

Do note that there are still errors that happen when the application is called.

sh: sysctl: command not found
sh: system_profiler: not found
sh: sysctl: command not found
sh: system_profiler: not found

This does, however, build and output mostly correct data. It is unable to detect the CPU or GPU or memory resolution. I'll look into this soon.

Full output located at https://gist.github.com/skyhighwings/112402e2c96712af9cbf

Tested on OSX 10.10 on my mid-2015 MBP.

sariyamelody commented 9 years ago

Actually, the memory one is more egregious than the rest. It reports -6875MB/0MB on my (16GB) laptop. Interesting.

woodruffw commented 9 years ago

Thanks for the PR, but 08f0bbeb979712bacb9d048cfa5424e863c03e36 should fix it.

I also fixed the "command not found" messages, and I'll be looking into the memory - that seems to be a 10.10 thing.

Thanks, William

sariyamelody commented 9 years ago

Thanks much! Sorry for the useless PR.

On 3/21/2015 3:41 PM, William Woodruff wrote:

Thanks for the PR, but 08f0bbe https://github.com/woodruffw/screenfetch-c/commit/08f0bbeb979712bacb9d048cfa5424e863c03e36 should fix it.

I also fixed the "command not found" messages, and I'll be looking into the memory - that seems to be a 10.10 thing.

Thanks, William

— Reply to this email directly or view it on GitHub https://github.com/woodruffw/screenfetch-c/pull/16#issuecomment-84452014.

Rylee Fowler PGP: 41EA 1D94 F261 8602 6CD4 B2B5 05A6 3421 F637 E333 Never heard of PGP? See https://emailselfdefense.fsf.org/en/ ! https://keybase.io/rylee

woodruffw commented 9 years ago

No sweat. Just tell me if you run into any more problems.

Edit: I'll be updating the homebrew formula in a few moments.

sariyamelody commented 9 years ago

It works! I'll be happy to test anything you need. Feel free to shoot me an email at the address listed on my GitHub page.

woodruffw commented 9 years ago

Awesome. I'll try to come up with some things you can test.