search

woodruffw / screenfetch-c

A rewrite of screenFetch in C.
MIT License
73 stars 17 forks source link

Failed to detect the Distro, WM. #19

Closed rmNULL closed 8 years ago

rmNULL commented 8 years ago

2015-10-27-174640_784x87_scrot

The particular problem is faced in Slackware, herbstluftwm was the WM used here. It would be nice if the software recognizes the WM and ignores the DE if only WM is installed. The slackware Ascii art is found in the original screenfetch. Thank you. :smile:

woodruffw commented 8 years ago

Could you tell me the contents of /etc/os-release? Additionally, please look for a file named /etc/slackware-release or something similar (most likely in /etc). Using that for detecting slackware would be ideal.

Does screenfetch-c report herbstluftwm correctly?

rmNULL commented 8 years ago

Contents of /etc/os-release[image attached]. 2015-10-28-135139_461x121_scrot The Slackware version is found in a file name /etc/slackware-version.

2) Does screenfetch-c report herbstluftwm correctly? No. It doesn't.

woodruffw commented 8 years ago

d196e6c2b02d234a452ee7523094dc5f06dfc4de should fix the detection of Slackware.

2) Does screenfetch-c report herbstluftwm correctly? No. It doesn't.

Does it report anything at all? If not, what error message does it produce?

woodruffw commented 8 years ago

It looks like herbstluftwm expects the user to set the value of the _NET_WM_NAME property manually.

https://github.com/herbstluftwm/herbstluftwm/blob/0c26a29512e311e81b74c6dae34a23bd2a892679/src/ewmh.cpp#L155:

void ewmh_update_wmname() {
    ewmh_set_wmname(settings_find_string("wmname"));
}

Setting the wmname property in herbstluftwm's configuration file to "herbstluftwm" (or whatever you want your WM to be called) should fix it. IIRC, XMonad has/had a similar problem with screenfetch-c (see https://github.com/woodruffw/screenfetch-c/issues/14).

woodruffw commented 8 years ago

Closing #19 (can be fixed in WM's configuration).