woodruffw / screenfetch-c

A rewrite of screenFetch in C.
MIT License
73 stars 17 forks source link

FreeBSD Issues #5

Closed KittyKatt closed 10 years ago

KittyKatt commented 10 years ago

Okay! Here we go.

I've fixed the following so far...

[x] - A problem in spacing for the FreeBSD logo [x] - Disk related errors for BSD. It was showing up as 438G / 11G (3182%) on mine. Grabbing the first line of df is unreliable. Also, there is not total shown in BSD df without -c AND it appears at the end. So, I've added that flag and converted head -1 to tail -1.

What's not done:

[ ] - Fix for memory detection. Do not rely on anything /proc related in BSD. It doesn't exist. /proc is mostly a purely linux thing. If you insist on relying on /proc, you're going to have to advise to BSD users to load the linux-compat kernel module that enables /proc. The original code in sF is quite extensive for *BSD mem detection. You may want to take a look at it. [ ] - Package detection is broken in 10.0-CURRENT, but mostly because of pkgng messing up my pkg dbs. I wouldn't worry about it too much.

woodruffw commented 10 years ago

Thanks!

Yeah, I'm well aware of the dangers of relying on /proc in BSD. I've been planning to use sysctl.h to alleviate screenfetch-c's reliance on it, although sysctl has it's own problems (may lack the facilities to detect > 4GB RAM)...

KittyKatt commented 10 years ago

Yeah. We'll have to figure out something. :)