False positive results when running Bootstrapper

wooga / Paket.Unity3D

An extension for the Paket dependency manager that enables the integration of NuGet dependencies into Unity3D projects.

http://wooga.github.io/Paket.Unity3D/

The Unlicense

42 stars 9 forks source link

False positive results when running Bootstrapper #19

Open Larusso opened 6 years ago

Larusso commented 6 years ago

The Bootstrapper fails only with exit code -1 if the to be downloaded program file doesn't exist. In case of IO errors with corrupted files means we have a false positive.

https://github.com/wooga/Paket.Unity3D/blob/1b233e51836cf5a0af450dcfb3f6f7b667371bcf/src/Paket.Unity3D.Bootstrapper/Program.cs#L132-L139

We should check the file checksum with the value provided by github.

marcolink commented 5 months ago

@Larusso should we close it? 😄

Larusso commented 5 months ago

Well it's been a while haha