woojiahao / Taiga

Discord administration bot
https://woojiahao.github.io/Taiga
MIT License
20 stars 12 forks source link

Reworking Command Framework #21

Closed woojiahao closed 5 years ago

woojiahao commented 5 years ago

Current command framework might bug if the command is overloaded with a sentence at the end:

Simulation

  1. Overload strike command to not receive the Integer() input
  2. This should default the strike to 1 with the reason
  3. Call the strike command
  4. With the current strike system, it should throw an exception that the first word in the sentence is not a valid input, this is not meant to happen

Fix

woojiahao commented 5 years ago

Not a possible fix given the current approach towards parsing arguments, will be closing this for now, might re-open if there is a better approach towards creating and parsing commands.